Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against node 15 #1138

merged 6 commits into from Oct 31, 2020

Test against node 15 #1138

merged 6 commits into from Oct 31, 2020


Copy link

@cspotcode cspotcode commented Oct 31, 2020

Add 3x new test matrix entries for node 15, against typescript 2.7, latest, and next

Fixed one test case, where we used a regexp to match an error stack from node. Internal node changes meant the stack is slightly different, so I updated the regexp to match.

node 15 comes with npm v7, but npm v7 has some buggy(?) changes to peerDependencies handling. I don't want to deal with this, so I avoid it by downgrading to npm v6.

Copy link

@codecov codecov bot commented Oct 31, 2020

Codecov Report

Merging #1138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1138   +/-   ##
  Coverage   79.32%   79.32%           
  Files           7        7           
  Lines         711      711           
  Branches      158      158           
  Hits          564      564           
  Misses         90       90           
  Partials       57       57           
Flag Coverage Δ
node_10 76.28% <ø> (ø)
node_12_15 76.63% <ø> (ø)
node_12_16 76.63% <ø> (ø)
node_13 79.04% <ø> (ø)
node_14 79.04% <ø> (ø)
node_15 79.04% <ø> (?)
typescript_2_7 78.90% <ø> (ø)
typescript_latest 78.19% <ø> (ø)
typescript_next 78.05% <ø> (ø)
ubuntu 79.04% <ø> (ø)
windows 79.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a90aac...1869ba1. Read the comment docs.

Copy link

@coveralls coveralls commented Oct 31, 2020

Coverage Status

Coverage increased (+0.9%) to 86.95% when pulling 1869ba1 on ab/test-node-15 into 5a90aac on master.

@cspotcode cspotcode added this to Hacktoberfest in Andrew Bradley's Tasks Oct 31, 2020
@cspotcode cspotcode marked this pull request as ready for review Oct 31, 2020
@cspotcode cspotcode merged commit a0f7aa1 into master Oct 31, 2020
29 checks passed
@cspotcode cspotcode moved this from Hacktoberfest to Merged to master in Andrew Bradley's Tasks Dec 3, 2020
@cspotcode cspotcode deleted the ab/test-node-15 branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Andrew Bradley's Tasks
Merged to master

Successfully merging this pull request may close these issues.

None yet

2 participants