Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading codecov failures #1159

Merged
merged 1 commit into from Nov 22, 2020
Merged

Fix misleading codecov failures #1159

merged 1 commit into from Nov 22, 2020

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Nov 22, 2020

Tweaks codecov configuration.

Project coverage is allowed to fall up to 1% and will still get the green checkmark.

Patch coverage has no requirements and will always succeed. I didn't feel like automatically-failing patch coverage was particularly useful. For example, if a patch changes 2 lines, and only one is covered, then patch coverage is 50%. This is IMO not necessarily a bad thing.

@codecov
Copy link

@codecov codecov bot commented Nov 22, 2020

Codecov Report

Merging #1159 (4068edc) into master (f848983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   79.60%   79.60%           
=======================================
  Files           7        7           
  Lines         711      711           
  Branches      158      158           
=======================================
  Hits          566      566           
  Misses         89       89           
  Partials       56       56           
Flag Coverage Δ
node_10 76.11% <ø> (ø)
node_12_15 76.46% <ø> (ø)
node_12_16 76.46% <ø> (ø)
node_13 78.90% <ø> (ø)
node_14 78.90% <ø> (ø)
node_14_13_0 78.05% <ø> (ø)
node_15 78.90% <ø> (ø)
typescript_2_7 78.90% <ø> (ø)
typescript_latest 78.05% <ø> (ø)
typescript_next 78.05% <ø> (ø)
ubuntu 78.76% <ø> (ø)
windows 78.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f848983...4068edc. Read the comment docs.

@cspotcode cspotcode merged commit 8b9489a into master Nov 22, 2020
29 checks passed
@cspotcode cspotcode deleted the ab/fix-codecov-failures branch Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant