Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version checks for v16 #1522

Merged
merged 3 commits into from Oct 21, 2021
Merged

Conversation

shrujalshah28
Copy link
Contributor

@shrujalshah28 shrujalshah28 commented Oct 19, 2021

@cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 19, 2021

Should be 16.12.0, right? Can we also add 16.11.0 to our test matrix, so that we are certain to test against 2x 16.x versions: one before the loader hooks changed, and one after?

@shrujalshah28
Copy link
Contributor Author

@shrujalshah28 shrujalshah28 commented Oct 20, 2021

Yes, Sure will try to add tests today.

@shrujalshah28
Copy link
Contributor Author

@shrujalshah28 shrujalshah28 commented Oct 20, 2021

@cspotcode #1007 needs to update to reflect the exact version number.

src/esm.ts Outdated Show resolved Hide resolved
@cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 20, 2021

@cspotcode #1007 needs to update to reflect the exact version number.

Thanks, I updated it under "node's API change: v16.12.0, v17.0.0"

@codecov
Copy link

@codecov codecov bot commented Oct 21, 2021

Codecov Report

Merging #1522 (d0a441d) into main (3b40365) will not change coverage.
The diff coverage is n/a.

Impacted Files Coverage Δ
src/esm.ts 84.21% <ø> (ø)

@cspotcode cspotcode merged commit b16134b into TypeStrong:main Oct 21, 2021
27 checks passed
@cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 21, 2021

@shrujalshah28 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants