Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data URL format determination in new loader hooks API #1529

Merged
merged 6 commits into from Oct 22, 2021
Merged

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Oct 21, 2021

Fixes #1526

Also fixes #1506

@cspotcode
Copy link
Collaborator Author

@cspotcode cspotcode commented Oct 21, 2021

Pushing twice, once to verify the tests fail, then again with the fix.

@codecov
Copy link

@codecov codecov bot commented Oct 21, 2021

Codecov Report

Merging #1529 (b5ff840) into main (8cde25b) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted Files Coverage Δ
dist-raw/node-primordials.js 59.09% <0.00%> (-2.82%) ⬇️
src/esm.ts 84.21% <100.00%> (ø)
src/index.ts 77.83% <100.00%> (ø)

@cspotcode cspotcode changed the title Fix data: URL format determination in new loader hooks API Fix data URL format determination in new loader hooks API Oct 22, 2021
@cspotcode cspotcode added this to the 10.3.2 milestone Oct 22, 2021
@cspotcode cspotcode merged commit 889c21d into main Oct 22, 2021
27 checks passed
@cspotcode cspotcode deleted the fix-1526 branch Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant