From 541fbcf93fedc499fee9579ad044b2fc67e3cfac Mon Sep 17 00:00:00 2001 From: Adam Epling Date: Thu, 27 Feb 2020 20:38:06 -0600 Subject: [PATCH] fix: Ensure child comment tags get set (#1221) * add comments array to reflection object * Fixed issue in CommentPlugin where comments were not always being entirely copied over to signature * Fixed CommentPlugin issue where tags weren't always being copied over to child comments inside signatures. Also updated test specs to match the expected output. Should now output the `@see` tags defined in the comments for the test fat arrow functions --- src/lib/converter/plugins/CommentPlugin.ts | 1 + src/test/renderer/specs/classes/_classes_.baseclass.html | 5 +++++ src/test/renderer/specs/classes/_classes_.subclassa.html | 5 +++++ src/test/renderer/specs/classes/_classes_.subclassb.html | 5 +++++ 4 files changed, 16 insertions(+) diff --git a/src/lib/converter/plugins/CommentPlugin.ts b/src/lib/converter/plugins/CommentPlugin.ts index 0ebd9aaf5..726f7618a 100644 --- a/src/lib/converter/plugins/CommentPlugin.ts +++ b/src/lib/converter/plugins/CommentPlugin.ts @@ -307,6 +307,7 @@ export class CommentPlugin extends ConverterComponent { childComment.shortText = childComment.shortText || comment.shortText; childComment.text = childComment.text || comment.text; childComment.returns = childComment.returns || comment.returns; + childComment.tags = childComment.tags || comment.tags; } if (signature.parameters) { diff --git a/src/test/renderer/specs/classes/_classes_.baseclass.html b/src/test/renderer/specs/classes/_classes_.baseclass.html index d1047b287..8d255e76c 100644 --- a/src/test/renderer/specs/classes/_classes_.baseclass.html +++ b/src/test/renderer/specs/classes/_classes_.baseclass.html @@ -287,6 +287,11 @@

arrowFunction

This is a simple fat arrow function.

+
+
see
+

https://github.com/sebastian-lenz/typedoc/issues/37

+
+

Parameters