From 990a794293419a31876e4e9ac448823f1c2c3cc0 Mon Sep 17 00:00:00 2001 From: Gerrit Birkeland Date: Fri, 2 Sep 2022 20:41:21 -0600 Subject: [PATCH] Remove dead method --- src/lib/output/renderer.ts | 20 ------------------- .../default/DefaultThemeRenderContext.ts | 4 +--- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/src/lib/output/renderer.ts b/src/lib/output/renderer.ts index 95f816bf0..2c8c05f92 100644 --- a/src/lib/output/renderer.ts +++ b/src/lib/output/renderer.ts @@ -113,10 +113,6 @@ export class Renderer extends ChildableComponent< ["default", DefaultTheme], ]); - private unknownSymbolResolvers: Array< - (ref: DeclarationReference) => string | undefined - > = []; - /** @event */ static readonly EVENT_BEGIN_PAGE = PageEvent.BEGIN; /** @event */ @@ -209,21 +205,6 @@ export class Renderer extends ChildableComponent< }); } - /** - * Marked as internal for now. Using this requires the internal `getSymbol()` method on ReferenceType. - * Someday that needs to be fixed so that this can be made public. ReferenceTypes really shouldn't store - * symbols so that we don't need to keep the program around forever. - * - * Remove in 0.24. - * @internal - */ - attemptExternalResolution(ref: DeclarationReference): string | undefined { - for (const resolver of this.unknownSymbolResolvers) { - const resolved = resolver(ref); - if (resolved) return resolved; - } - } - /** * Render the given project reflection to the specified output directory. * @@ -392,4 +373,3 @@ export class Renderer extends ChildableComponent< // HACK: THIS HAS TO STAY DOWN HERE // if you try to move it up to the top of the file, then you'll run into stuff being used before it has been defined. import "./plugins"; -import type { DeclarationReference } from "../converter/comments/declarationReference"; diff --git a/src/lib/output/themes/default/DefaultThemeRenderContext.ts b/src/lib/output/themes/default/DefaultThemeRenderContext.ts index ea96582b0..af3c4928f 100644 --- a/src/lib/output/themes/default/DefaultThemeRenderContext.ts +++ b/src/lib/output/themes/default/DefaultThemeRenderContext.ts @@ -80,9 +80,7 @@ export class DefaultThemeRenderContext { * Will be removed in 0.24. */ attemptExternalResolution = (type: NeverIfInternal) => { - return this.theme.owner.attemptExternalResolution( - (type as ReferenceType).toDeclarationReference() - ); + return (type as ReferenceType).externalUrl; }; reflectionTemplate = bind(reflectionTemplate, this);