Skip to content

/my-outstanding-balance

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format the "total interest" value in PayoffProjectionContainer to display as a dollar value #27

Closed
Tyresius92 opened this issue Oct 28, 2019 · 4 comments · Fixed by #30
Labels
Good First Issue Priority: Medium Status: Ready to Implement Type: Bug

Comments

@Tyresius92
Copy link
Owner

@Tyresius92 Tyresius92 commented Oct 28, 2019

Describe the bug
Currently, the total interest value in PayoffProjectionContainer displays as a very long float value.

Expected behavior
Update the formatting to display as a dollar value. (i.e. Total Interest: $123.45)
@izhuravlev

This comment has been minimized.

Sign in to view
Copy link
Contributor

@izhuravlev izhuravlev commented Oct 28, 2019

Hey @Tyresius92,
Can I work on that?
@Tyresius92

This comment has been minimized.

Sign in to view
Copy link
Owner Author

@Tyresius92 Tyresius92 commented Oct 28, 2019

Hi @izhuravlev! Sure go for it! Please let me know if you have any questions.
@izhuravlev

This comment has been minimized.

Sign in to view
Copy link
Contributor

@izhuravlev izhuravlev commented Oct 29, 2019

Hey @Tyresius92 ,
What configurations do you run Prettier with? Can't make a commit because of the Prettier prechecker.

All in all, my corrections look like this:
Capture
@izhuravlev izhuravlev mentioned this issue Oct 29, 2019
Merged
@Tyresius92

This comment has been minimized.

Sign in to view
Copy link
Owner Author

@Tyresius92 Tyresius92 commented Oct 29, 2019

Hi @izhuravlev Thank you! The PR looks good. Just going to sanity check locally and then I'll merge it in.

Re: prettier - were you not able to just run prettier on the file? I thought I had it configured to pick up the settings from package.json. Was that not the case?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Priority: Medium Status: Ready to Implement Type: Bug
Projects
None yet
Milestone
No milestone
2 participants
@Tyresius92 @izhuravlev
You can’t perform that action at this time.