-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triangle simd support #28
Open
MarvinChung
wants to merge
35
commits into
TzuChieh:develop
Choose a base branch
from
MarvinChung:triangle-simd-PR
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okay, I will add libsimdpp to build script in 24 hours |
TzuChieh
reviewed
Mar 15, 2019
EngineTest/Source/Core/Intersectable/SIMD_triangle_intersection_test.cpp
Outdated
Show resolved
Hide resolved
TzuChieh
reviewed
Mar 15, 2019
TzuChieh
reviewed
Mar 15, 2019
Engine/Source/Core/Intersectable/triangle_SIMD_Bvh/SIMD_triangle_intersection.h
Outdated
Show resolved
Hide resolved
TzuChieh
reviewed
Mar 16, 2019
EngineTest/Source/Core/Intersectable/SIMD_triangle_intersection_test.cpp
Outdated
Show resolved
Hide resolved
please try your best to make the tests pass (no pressure, just try :)) |
remove Engine/Source/Core/Intersectable/triangle_SIMD_Bvh/SIMD_triangle_intersection.cpp
The commit is not passing due to the google test does not pass. However not passing is doing on purpose, all other compiling is remain usual. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not stable yet, google test has not apply.