Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruleset: CardExpander: buttons and relevant UI changes #114

Merged
merged 2 commits into from
May 16, 2024
Merged

Ruleset: CardExpander: buttons and relevant UI changes #114

merged 2 commits into from
May 16, 2024

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Apr 4, 2024 •
edited
Loading

Issue: #113

  • moved buttons to Expander Header
  • split text controls
  • use ruleset.RuleName to be specific
  • removed the Grid Columns to better use width

image

@Jay-o-Way
first round
bc12d7b 
split controls
use 'RuleName' to be specific
@Jay-o-Way Jay-o-Way marked this pull request as ready for review April 9, 2024 15:54
@U-C-S
Copy link
Owner

U-C-S commented Apr 14, 2024

I'm currently on Vacation. Will take a look at this next week.

@U-C-S U-C-S mentioned this pull request Apr 18, 2024
Closed
@U-C-S U-C-S merged commit 47f525c into U-C-S:main May 16, 2024
@Jay-o-Way Jay-o-Way deleted the buttons-in-expander branch May 16, 2024 10:09
@Jay-o-Way Jay-o-Way restored the buttons-in-expander branch May 16, 2024 10:16
@Jay-o-Way Jay-o-Way deleted the buttons-in-expander branch May 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@U-C-S U-C-S U-C-S left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jay-o-Way @U-C-S