Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSDL compiler #122

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
3 participants
@fvantienen
Copy link

commented May 10, 2019

This updates the compiler to the newest pydsdl version. See #121

@pavel-kirienko pavel-kirienko requested a review from aasmune May 10, 2019

@pavel-kirienko pavel-kirienko self-requested a review May 10, 2019

@aasmune
Copy link
Member

left a comment

Looks good to me. I assume you have verified that the result is identical to before?

@fvantienen

This comment has been minimized.

Copy link
Author

commented May 13, 2019

I could not verify that because I don't know how to compile the previous version? So someone else needs to verify that.

@pavel-kirienko

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@aasmune I suggest we merge this regardless, seeing as the target branch is a staging branch and a rewrite of the code generator is imminent anyway.

@aasmune aasmune merged commit 958e0a7 into UAVCAN:uavcan-v1.0 May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.