Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification to TID handling and new tests to cover TID and timeout #132

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@mike7c2
Copy link

commented Jul 1, 2019

We found an issue where sometimes receiving packets would fail following a packet timing out. This commit makes the TID handling more consistent - the rx state TID is no longer incremented when a packet is succesfully decoded/fails - previously it would be incremented to the "next expected" TID.

Tests have been added to cover various TID/timeout scenarios.

mike7c2 added some commits Jul 1, 2019

mike7c2
Add more test cases and modify TID handling. Without these changes a …
…transfer which is pruned due to timeout with cleanupStaleTransfers would behave differently to one which is pruned when tid_timed_out is triggered in canardHandleRXFrame.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.