Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress on the media layer #245

Merged

Conversation

Projects
None yet
2 participants
@thirtytwobits
Copy link
Contributor

commented Jun 8, 2019

  1. some docs cleanup.
  2. completed the time.hpp unit tests.
  3. Added timestamps to the can frame
  4. Added formal way to change the microsecond types used by the library.
doc-upload
Progress on the media layer
1. some docs cleanup.
2. completed the time.hpp unit tests.
3. Added timestamps to the can frame
4. Added formal way to change the microsecond types used by the library.

@thirtytwobits thirtytwobits requested a review from pavel-kirienko Jun 8, 2019

@thirtytwobits

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

You can ignore the last change as it is just infrastructure stuff you didn't want to get involved in. Getting coverage reports for C++11 is HARD, it turns out. Jeebus.

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:uavcan-v1/issues/222 branch from 9d461fe to 4770a66 Jun 8, 2019

@pavel-kirienko
Copy link
Member

left a comment

Oops, I just noticed that the microsecond type width is still configurable.

@thirtytwobits

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Oops, I just noticed that the microsecond type width is still configurable.

But not really? It's configurable if you use the Base type but not for how the library will use Monotonic types.

@pavel-kirienko

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

But not really? It's configurable if you use the Base type but not for how the library will use Monotonic types.

I mean why do we need the LIBUAVCAN_MICROSECOND_SIZE_BYTES build config parameter?

doc-upload added some commits Jun 8, 2019

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:uavcan-v1/issues/222 branch from 14cc7d4 to 6a4d386 Jun 8, 2019

@thirtytwobits

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

LIBUAVCAN_MICROSECOND_SIZE_BYTES

ack! Crap. Sorry, fixing...

doc-upload

@thirtytwobits thirtytwobits merged commit 87ef785 into UAVCAN:uavcan-v1.0 Jun 8, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
buildkite/libuavcan-v1/pr Build #107 passed (3 minutes, 29 seconds)
Details
coverage/coveralls Coverage increased (+3.2%) to 84.689%
Details

@thirtytwobits thirtytwobits deleted the thirtytwobits:uavcan-v1/issues/222 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.