Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of #23 Stropping and #62 Add globals #65

Closed
wants to merge 0 commits into from

Conversation

@thirtytwobits
Copy link
Contributor

commented Sep 5, 2019

This is a complete PR for the Stropping implementation and the library
access to add globals with some other work on #64 mixed in. It is not
a 1.1.3 release candidate until #64 is complete.

src/nunavut/jinja/lang/__init__.py Outdated Show resolved Hide resolved
src/nunavut/jinja/lang/c.py Outdated Show resolved Hide resolved

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:master branch 2 times, most recently from 59f960b to 65d9d54 Sep 5, 2019

@pavel-kirienko

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

_ as a prefix won't work for Python because by convention it affects the member visibility. In Python, underscores should be appended instead.

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:master branch from 65d9d54 to 0eeb3c3 Sep 6, 2019

@thirtytwobits thirtytwobits requested a review from pavel-kirienko Sep 6, 2019

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:master branch from ccce192 to 909e792 Sep 6, 2019

@thirtytwobits thirtytwobits force-pushed the thirtytwobits:master branch from e6a4ee0 to 8435d4e Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.