Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a quick interface for building a JSON-serializable representat… #69

Open
wants to merge 1 commit into
base: master
from

Conversation

@thirtytwobits
Copy link
Contributor

commented Aug 10, 2019

Example:

{
  'ts_real': 1552523947.267123,
  'transfer_priority': 4,
  'source_node_id': 121,
  'fields': {
    'vendor_specific_status_code': 0,
    'uptime_sec': 11,
    'mode': 3,
    'health': 0,
    'sub_mode': 0
  },
  'ts_monotonic': 191910.2855129242,
  'datatype': 'uavcan.protocol.NodeStatus',
  'transfer_type': 'Message',
  'dest_node_id': None
}
Create a quick interface for building a JSON-serializable representat…
…ions of UAVCAN messages

Example:
```
{
  'ts_real': 1552523947.267123,
  'transfer_priority': 4,
  'source_node_id': 121,
  'fields': {
    'vendor_specific_status_code': 0,
    'uptime_sec': 11,
    'mode': 3,
    'health': 0,
    'sub_mode': 0
  },
  'ts_monotonic': 191910.2855129242,
  'datatype': 'uavcan.protocol.NodeStatus',
  'transfer_type': 'Message',
  'dest_node_id': None
}
```
@pavel-kirienko
Copy link
Member

left a comment

This would appear to be a port of to_builtin() from v1. An inverse function is also available there.

@thirtytwobits

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

This is actually a change another engineer on my team made to v0. Should we just port the v1 version back to v0 for consistency?

@pavel-kirienko

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

I don't think there's much difference so whatever you find best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.