Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collections Deprecation Warning #81

Conversation

@ImXron
Copy link

commented Oct 9, 2019

Minor change to get rid of a deprecation warning in 3.7

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Ref: https://docs.python.org/3/whatsnew/3.7.html#id3

@ImXron

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

Looking into the python 2 build fail.

@ImXron

This comment has been minimized.

Copy link
Author

commented Oct 9, 2019

I'm not very proud of the fix for python2 support, was trying to respect the style guide. Let me know what you prefer!

@pavel-kirienko pavel-kirienko merged commit 462889b into UAVCAN:master Oct 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pavel-kirienko

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

This is good, thank you Imran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.