Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand helix boundaries based on offsets after mirroring strands #368

Open
dave-doty opened this issue Jul 11, 2020 · 1 comment
Open

expand helix boundaries based on offsets after mirroring strands #368

dave-doty opened this issue Jul 11, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dave-doty
Copy link
Member

dave-doty commented Jul 11, 2020

On this design:

image

If you select reflect the strand horizontally, it goes outside the bounds of helix 1:

image

This should be checked and prevented in check_mirror_strands_legal_middleware.

UPDATE: I no longer want to prevent this reflection. Now I think it's a better idea to simply expand the necessary helices, in accordance with eventually implementing #579.

@dave-doty dave-doty added the bug Something isn't working label Jul 11, 2020
sarahayu added a commit that referenced this issue Jun 21, 2022
@dave-doty dave-doty changed the title check offsets after reflecting strands to ensure offsets are within helix boundaries expand helix boundaries based on offsets after reflecting strands Jun 25, 2022
@dave-doty dave-doty changed the title expand helix boundaries based on offsets after reflecting strands expand helix boundaries based on offsets after mirroring strands Jun 28, 2022
@dave-doty
Copy link
Member Author

@abhishekgokhale Note this is related to issue #579. It can be implemented separately if that's easier, but keep it in mind when working on #579.

dave-doty added a commit that referenced this issue Aug 8, 2023
…o-ensure-offsets-are-within-helix-boundaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants