Skip to content

Rewritten - fixed all notices and errors - reference only #20

Closed
scarstens opened this Issue Jul 17, 2012 · 6 comments

4 participants

@scarstens

We used your code to build our own updater function. Biggest difference being we were doing it for theme inclusion instead of plugin inclusion. Several items were removed and several other items were hard coded. Please not this gist is the codes current state within our theme but hopefully it may have some references on how to fix your plugin to work correctly on WordPress again.

https://gist.github.com/3133020

@danyork
danyork commented Jul 18, 2012

Very cool! So by the subject line I assume you mean that you fixed all the errors we were finding in #16, #18 and #19 ?

And when you say "theme inclusion" do you mean that you are directly adding this into a theme versus requiring it be used as a plugin?

In a quick look at the code I do see where you've hard-coded various aspects and in particular where you are focusing this on only one theme. It will be interesting to see if what you've done can fix the more generic case of looking at all the themes.

Many thanks for providing this.

(P.S. I'm not one of the core developers of this plugin but am a very interested user as I need it for some projects.)

@scarstens

I'm not really sure if it fixes those issues. I found this in Guthub, noted that it failed miserably and then ported it directly into the theme. Yes, it now works from within the theme and updates via WordPress from Github using the Github API to compare tag versions. You can see it in action here... when we update of course!

https://github.com/scarstens/whitelabel-framework

Easier install with the download from the official website:
http://whitelabelframework.com/

@ncsumarit

Thanks for sharing. I picked through your stuff and think I snagged the correct pieces to try to apply the updater to my theme but it doesn't appear to be working. Here's my theme - if you notice any obvious pieces that I didn't apply, please let me know: https://github.com/ncsuwebdev/WordPress-theme--OITFlex.git.

Appreciate it!

@scarstens

@ncsumarit it looks like you converted it into a class... its hard to tell there is a lot going on in there.

@conover conover was assigned Jul 23, 2012
@conover
University of Central Florida member
conover commented Jul 23, 2012

I'm working to incorporate these changes into this repo. Expect the plugin to be updated on the WordPress plugin page by the end of the day.

@conover
University of Central Florida member
conover commented Jul 23, 2012

Incorporated the changes while preserving the style.css directives.

@conover conover closed this Jul 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.