Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover): change default zIndex to 1030 of popover #150

Merged
merged 2 commits into from Jun 27, 2019

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

@ZxBing0066 ZxBing0066 added the feature New feature or request label Jun 27, 2019
@ZxBing0066 ZxBing0066 self-assigned this Jun 27, 2019
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   84.21%   84.21%           
=======================================
  Files         145      145           
  Lines        2641     2641           
  Branches      616      616           
=======================================
  Hits         2224     2224           
  Misses        389      389           
  Partials       28       28
Impacted Files Coverage Δ
src/components/Select/Select.jsx 90.36% <ø> (ø) ⬆️
src/components/Popover/style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873ee5d...cd3c1aa. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit e9bbccc into master Jun 27, 2019
Develop automation moved this from To do to Done Jun 27, 2019
@ZxBing0066 ZxBing0066 deleted the popover-zindex branch June 27, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant