Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add empty content for none option display #232

Merged
merged 2 commits into from Jul 8, 2020

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

@ZxBing0066 ZxBing0066 added the feature New feature or request label Jul 7, 2020
@ZxBing0066 ZxBing0066 self-assigned this Jul 7, 2020
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #232 into master will decrease coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   81.10%   81.09%   -0.01%     
==========================================
  Files         176      176              
  Lines        3588     3592       +4     
  Branches      866      839      -27     
==========================================
+ Hits         2910     2913       +3     
- Misses        588      597       +9     
+ Partials       90       82       -8     
Impacted Files Coverage Δ
src/components/Checkbox/style/index.js 100.00% <ø> (ø)
src/components/Select/style/index.js 93.75% <66.66%> (-6.25%) ⬇️
src/components/Select/Select.jsx 90.32% <100.00%> (+0.21%) ⬆️
src/components/Input/Input.jsx 75.00% <0.00%> (ø)
src/components/Table/Table.jsx 81.08% <0.00%> (ø)
src/components/Upload/Selector.jsx 11.11% <0.00%> (ø)
src/components/DatePicker/Range.jsx 52.50% <0.00%> (ø)
src/components/Table/ResizableTH.jsx 61.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c6589...23b3320. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit d378a91 into master Jul 8, 2020
Develop automation moved this from To do to Done Jul 8, 2020
@ZxBing0066 ZxBing0066 deleted the select-empty branch July 8, 2020 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant