refactor(builder): generateFlexChangesBundle should not rely on existing manifest.json #1218
+79
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Upport of SAP/ui5-builder#1178 |
…ing manifest.json When running the `generateFlexChangesBundle` task, `manifest.json` might not be present. Follow-up of #1165
d3xter666
force-pushed
the
fix-flex-change
branch
from
713dd92 to
428a7a6
Compare
matz3
approved these changes
Nov 27, 2025
Member
|
I thought upports should not appear in the changelog. Will we always modify the changelog or use a different prefix in the commit message? |
Member
Author
I think we discussed the |
d3xter666
changed the title
Member
|
https://github.com/UI5/cli/blob/v4/docs/Guidelines.md#implementing-fixes-across-v4-and-main-branches currently doesn't mention which prefix to use specifically. This should be enhanced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the
generateFlexChangesBundletask,manifest.jsonmight not be present.Follow-up of #1165