From 17bb066020eed710989641a3ca2ad6981249cd88 Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Fri, 24 Jan 2025 11:11:38 +0100 Subject: [PATCH] docs(SelectDialog): use `onSelectionChange` event instead of `onItemClick` --- packages/main/src/components/SelectDialog/SelectDialog.mdx | 4 ++-- .../main/src/components/SelectDialog/SelectDialog.stories.tsx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/main/src/components/SelectDialog/SelectDialog.mdx b/packages/main/src/components/SelectDialog/SelectDialog.mdx index 60cda47cd88..e42bf4406e9 100644 --- a/packages/main/src/components/SelectDialog/SelectDialog.mdx +++ b/packages/main/src/components/SelectDialog/SelectDialog.mdx @@ -92,7 +92,7 @@ const MultiSelectDialog = () => { }; // select/unselect const handleItemClick = (e) => { - const itemDescription = e.detail.item.dataset.description; + const itemDescription = e.detail.targetItem.dataset.description; setSelectedItems((prev) => { if (prev[itemDescription]) { const { [itemDescription]: _omit, ...rest } = prev; @@ -122,7 +122,7 @@ const MultiSelectDialog = () => { open={dialogOpen} mode={ListSelectionMode.Multiple} numberOfSelectedItems={Object.keys(selectedItems).length} - listProps={{ onItemClick: handleItemClick }} + listProps={{ onSelectionChange: handleItemClick }} showClearButton rememberSelections onClear={handleClear} diff --git a/packages/main/src/components/SelectDialog/SelectDialog.stories.tsx b/packages/main/src/components/SelectDialog/SelectDialog.stories.tsx index aa99f341169..b6961c8541d 100644 --- a/packages/main/src/components/SelectDialog/SelectDialog.stories.tsx +++ b/packages/main/src/components/SelectDialog/SelectDialog.stories.tsx @@ -99,7 +99,7 @@ export const MultiSelect: Story = { }; // select/unselect const handleItemClick = (e) => { - const itemDescription = e.detail.item.dataset.description; + const itemDescription = e.detail.targetItem.dataset.description; setSelectedItems((prev) => { if (prev[itemDescription]) { const { [itemDescription]: _omit, ...rest } = prev; @@ -129,7 +129,7 @@ export const MultiSelect: Story = { open={dialogOpen} selectionMode={ListSelectionMode.Multiple} numberOfSelectedItems={Object.keys(selectedItems).length} - listProps={{ onItemClick: handleItemClick }} + listProps={{ onSelectionChange: handleItemClick }} showClearButton rememberSelections onClear={handleClear}