Skip to content

fix(Assets): exclude -fetch assets & remove unsupported Assets-static.js #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

fix(Assets): exclude -fetch assets & remove unsupported Assets-static.js #7344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions packages/main/scripts/generateI18n.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,14 @@ spawnSync('npx', ['prettier', '--write', path.resolve(SRC_I18N_PROPERTIES, 'i18n
stdio: [0, 1, 2],
});

// generate Assets.js and Assets-static.js
// generate Assets.js
const jsonImports = await readdir(TARGET_I18N_JSON_IMPORTS);

const assets = [`import '@ui5/webcomponents/dist/Assets.js';`, `import '@ui5/webcomponents-fiori/dist/Assets.js';`];
const assetsStatic = [
`import '@ui5/webcomponents/dist/Assets-static.js';`,
`import '@ui5/webcomponents-fiori/dist/Assets-static.js';`,
];

for (const file of jsonImports) {
if (file.includes('-static')) {
assetsStatic.push(`import './json-imports/${file}';`);
if (file.includes('-fetch')) {
//todo: add to Assets-fetch.js
} else {
assets.push(`import './json-imports/${file}';`);
}
Expand All @@ -75,7 +71,3 @@ await writeFile(
path.resolve(DIST_DIR, 'Assets.js'),
await prettier.format(assets.join('\n'), { ...prettierConfig, parser: 'babel' }),
);
await writeFile(
path.resolve(DIST_DIR, 'Assets-static.js'),
await prettier.format(assetsStatic.join('\n'), { ...prettierConfig, parser: 'babel' }),
);
Loading