From 67dc71b9639c8f8497ae44225287f6680390b8cc Mon Sep 17 00:00:00 2001 From: Lukas Harbarth Date: Tue, 12 May 2026 13:53:30 +0200 Subject: [PATCH 1/2] fix(ObjectPage): prevent header collapse on IconTabBar tab switch --- .../components/ObjectPage/ObjectPage.cy.tsx | 44 ++++++++++++++----- .../main/src/components/ObjectPage/index.tsx | 12 ++++- .../components/ObjectPageSection/index.tsx | 1 + 3 files changed, 43 insertions(+), 14 deletions(-) diff --git a/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx b/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx index 337c892819c..ead0f5d8839 100644 --- a/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx +++ b/packages/main/src/components/ObjectPage/ObjectPage.cy.tsx @@ -114,7 +114,7 @@ describe('ObjectPage', () => { cy.get('[ui5-tabcontainer]').findUi5TabByText('Section 15').should('have.attr', 'aria-selected', 'true'); if (mode === ObjectPageMode.Default) { - cy.findByTestId('op').scrollTo(0, 4858); + cy.findByTestId('op').scrollTo(0, 4878); cy.findByText('Content 7').should('be.visible'); cy.get('[ui5-tabcontainer]').findUi5TabByText('Section 7').should('have.attr', 'aria-selected', 'true'); @@ -124,7 +124,7 @@ describe('ObjectPage', () => { for (let i = 0; i < 15; i++) { cy.findByText('Add').click(); } - cy.findByTestId('op').scrollTo(0, 4858); + cy.findByTestId('op').scrollTo(0, 4878); cy.findByText('Content 7').should('be.visible'); cy.get('[ui5-tabcontainer]').findUi5TabByText('Section 7').should('have.attr', 'aria-selected', 'true'); @@ -754,11 +754,11 @@ describe('ObjectPage', () => { cy.mount(); cy.findByText('Update Heights').click(); - cy.findByText('{"offset":1080,"scroll":2320}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2330}').should('exist'); cy.findByTestId('op').scrollTo('bottom'); cy.findByText('Update Heights').click({ force: true }); - cy.findByText('{"offset":1080,"scroll":2320}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2330}').should('exist'); cy.mount(); cy.findByText('Update Heights').click(); @@ -812,19 +812,19 @@ describe('ObjectPage', () => { cy.get('[data-component-name="ObjectPageTabContainer"]').should('not.exist'); cy.findByText('Update Heights').click(); - cy.findByText('{"offset":1080,"scroll":2240}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2250}').should('exist'); cy.findByTestId('op').scrollTo('bottom'); cy.findByText('Update Heights').click({ force: true }); - cy.findByText('{"offset":1080,"scroll":2240}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2250}').should('exist'); cy.mount(); cy.findByText('Update Heights').click(); - cy.findByText('{"offset":1080,"scroll":2300}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2310}').should('exist'); cy.findByTestId('op').scrollTo('bottom'); cy.findByText('Update Heights').click({ force: true }); - cy.findByText('{"offset":1080,"scroll":2300}').should('exist'); + cy.findByText('{"offset":1080,"scroll":2310}').should('exist'); cy.mount(); cy.findByText('Update Heights').click(); @@ -1299,6 +1299,13 @@ describe('ObjectPage', () => { > Select Goals +