-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ui5-calendar): introduce Year Range Picker #11167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I changed the "focused date" to be the 10th grid date (in normal year view) instead of the 11th since it is more centered, and we discussed this with the designers that it would be preferable for the focus to be in the upper left of the "center". I believe the date change was caused by that. I will confirm with the designers again if this is correct. For the year range view, the centered date is the 3rd one always.
the rectangles in openui5 aren't according to spec, they text reaches where the border is supposed to be, as for year picker vs year-range-picker, you're right, they seem to be ever so slightly thinner, I will check that. |
vladitasev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! I didn't test much but from what I did, F4 on year picker does not trigger year range picker (as it says in the commit)
Already has an approval from Vladi :)
Corrected it to the following:
Also keep in mind that on mac it's |
|
🎉 This PR is included in version v2.11.0-rc.4 🎉 The release is available on v2.11.0-rc.4 Your semantic-release bot 📦🚀 |
With this change we introduce the new picker component
ui5-yearrange-pickerwhich users can use to quickly navigate through a range of years.Selecting the header or pressing
shift+f4, in the in Year picker, will open the Year Range pickerDemo:
More examples:
[Left] Like in the Year picker, dates before the
min-datewill not be shown, and dates after themax-datewill be disabled[Right] Year Range picker with
primary-calendar-type="Islamic"andsecondary-calendar-type="Gregorian"Fixes: #3200
Fixes: #11011
Fixes: #10867