From 3b88ecb92897d141308d2af66637ddcb8030933c Mon Sep 17 00:00:00 2001 From: Deshev Date: Fri, 5 Sep 2025 10:55:34 +0300 Subject: [PATCH 1/4] fix(ui5-textarea): adjust width in high contrast themes fixes: #12229 --- packages/main/src/themes/TextArea.css | 2 +- packages/main/src/themes/base/TextArea-parameters.css | 4 +++- .../main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css | 4 +++- .../main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css | 4 +++- packages/main/src/themes/sap_horizon/TextArea-parameters.css | 2 ++ .../main/src/themes/sap_horizon_dark/TextArea-parameters.css | 4 +++- .../main/src/themes/sap_horizon_hcb/TextArea-parameters.css | 4 +++- .../main/src/themes/sap_horizon_hcw/TextArea-parameters.css | 4 +++- 8 files changed, 21 insertions(+), 7 deletions(-) diff --git a/packages/main/src/themes/TextArea.css b/packages/main/src/themes/TextArea.css index 3f574438136c..adb5f1d7248c 100644 --- a/packages/main/src/themes/TextArea.css +++ b/packages/main/src/themes/TextArea.css @@ -140,7 +140,7 @@ :host([growing]) .ui5-textarea-inner { box-sizing: border-box; height: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); - width: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); + width: var(--_ui5_textarea_inner_width, calc(100% - (2 * var(--_ui5_textarea_wrapper_padding)))); position: absolute; } diff --git a/packages/main/src/themes/base/TextArea-parameters.css b/packages/main/src/themes/base/TextArea-parameters.css index 534a5e5017d6..b22bc5f93a6d 100644 --- a/packages/main/src/themes/base/TextArea-parameters.css +++ b/packages/main/src/themes/base/TextArea-parameters.css @@ -27,6 +27,8 @@ --_ui5_textarea_success_wrapper_padding: 0; --_ui5_textarea_warning_error_wrapper_padding: 0; --_ui5_textarea_information_wrapper_padding: 0; + /* Fix for growing textarea width when wrapper padding is 0 */ + --_ui5_textarea_inner_width: 100%; --_ui5_textarea_padding_right_and_left: 0.5625rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5rem; @@ -60,4 +62,4 @@ --_ui5_textarea_padding_bottom_information: 0.0625rem; --_ui5_textarea_margin: 0.1875rem 0; --_ui5_textarea_min_height: 1.625rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css index 992c1dd0b5dd..91f4f139c6cd 100644 --- a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css @@ -19,6 +19,8 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; + /* Fix for growing textarea width when wrapper padding is 0 */ + --_ui5_textarea_inner_width: 100%; } [data-ui5-compact-size], @@ -35,4 +37,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css index 82ac1922e641..ed54967bf2a0 100644 --- a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css @@ -19,6 +19,8 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; + /* Fix for growing textarea width when wrapper padding is 0 */ + --_ui5_textarea_inner_width: 100%; } [data-ui5-compact-size], @@ -35,4 +37,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_horizon/TextArea-parameters.css b/packages/main/src/themes/sap_horizon/TextArea-parameters.css index ad8fdd6163a1..c523e9ce553f 100644 --- a/packages/main/src/themes/sap_horizon/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon/TextArea-parameters.css @@ -20,6 +20,8 @@ --_ui5_textarea_success_wrapper_padding: 0.0625rem; --_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; --_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; + /* Override base theme fix since this theme has non-zero wrapper padding */ + --_ui5_textarea_inner_width: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); --_ui5_textarea_padding_top: 0.5rem; --_ui5_textarea_padding_bottom: 0.4375rem; --_ui5_textarea_padding_bottom_readonly: 0.375rem; diff --git a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css index 54a9d2b519d0..00d6e19dd41c 100644 --- a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css @@ -20,6 +20,8 @@ --_ui5_textarea_success_wrapper_padding: 0.0625rem; --_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; --_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; + /* Override base theme fix since this theme has non-zero wrapper padding */ + --_ui5_textarea_inner_width: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); --_ui5_textarea_padding_top: 0.5rem; --_ui5_textarea_padding_bottom: 0.4375rem; --_ui5_textarea_padding_bottom_readonly: 0.375rem; @@ -46,4 +48,4 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css index 945d80906452..6284250f86f7 100644 --- a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css @@ -23,6 +23,8 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; + /* Fix for growing textarea width when wrapper padding is 0 */ + --_ui5_textarea_inner_width: 100%; } [data-ui5-compact-size], @@ -39,4 +41,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css index 7d8abf39bf0c..3590773732cd 100644 --- a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css @@ -23,6 +23,8 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; + /* Fix for growing textarea width when wrapper padding is 0 */ + --_ui5_textarea_inner_width: 100%; } [data-ui5-compact-size], @@ -39,4 +41,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} \ No newline at end of file +} From bedd67400c46bcffb91e9345d9ac75ad118d7d36 Mon Sep 17 00:00:00 2001 From: Deshev Date: Fri, 5 Sep 2025 11:03:56 +0300 Subject: [PATCH 2/4] fix(ui5-textarea): adjust width in high contrast themes remove new lines --- packages/main/src/themes/base/TextArea-parameters.css | 1 - .../main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css | 1 - .../main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css | 1 - packages/main/src/themes/sap_horizon/TextArea-parameters.css | 3 +-- .../main/src/themes/sap_horizon_dark/TextArea-parameters.css | 1 - .../main/src/themes/sap_horizon_hcb/TextArea-parameters.css | 1 - .../main/src/themes/sap_horizon_hcw/TextArea-parameters.css | 1 - 7 files changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/main/src/themes/base/TextArea-parameters.css b/packages/main/src/themes/base/TextArea-parameters.css index b22bc5f93a6d..bf0307adc2f1 100644 --- a/packages/main/src/themes/base/TextArea-parameters.css +++ b/packages/main/src/themes/base/TextArea-parameters.css @@ -27,7 +27,6 @@ --_ui5_textarea_success_wrapper_padding: 0; --_ui5_textarea_warning_error_wrapper_padding: 0; --_ui5_textarea_information_wrapper_padding: 0; - /* Fix for growing textarea width when wrapper padding is 0 */ --_ui5_textarea_inner_width: 100%; --_ui5_textarea_padding_right_and_left: 0.5625rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; diff --git a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css index 91f4f139c6cd..5e3ddd617e31 100644 --- a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css @@ -19,7 +19,6 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; - /* Fix for growing textarea width when wrapper padding is 0 */ --_ui5_textarea_inner_width: 100%; } diff --git a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css index ed54967bf2a0..b8315738c64c 100644 --- a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css @@ -19,7 +19,6 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; - /* Fix for growing textarea width when wrapper padding is 0 */ --_ui5_textarea_inner_width: 100%; } diff --git a/packages/main/src/themes/sap_horizon/TextArea-parameters.css b/packages/main/src/themes/sap_horizon/TextArea-parameters.css index c523e9ce553f..0b14393592d7 100644 --- a/packages/main/src/themes/sap_horizon/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon/TextArea-parameters.css @@ -20,7 +20,6 @@ --_ui5_textarea_success_wrapper_padding: 0.0625rem; --_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; --_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; - /* Override base theme fix since this theme has non-zero wrapper padding */ --_ui5_textarea_inner_width: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); --_ui5_textarea_padding_top: 0.5rem; --_ui5_textarea_padding_bottom: 0.4375rem; @@ -48,4 +47,4 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5rem; -} \ No newline at end of file +} diff --git a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css index 00d6e19dd41c..5b0097fcc086 100644 --- a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css @@ -20,7 +20,6 @@ --_ui5_textarea_success_wrapper_padding: 0.0625rem; --_ui5_textarea_warning_error_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; --_ui5_textarea_information_wrapper_padding: 0.0625rem 0.0625rem 0.125rem 0.0625rem; - /* Override base theme fix since this theme has non-zero wrapper padding */ --_ui5_textarea_inner_width: calc(100% - (2 * var(--_ui5_textarea_wrapper_padding))); --_ui5_textarea_padding_top: 0.5rem; --_ui5_textarea_padding_bottom: 0.4375rem; diff --git a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css index 6284250f86f7..01d9625cba56 100644 --- a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css @@ -23,7 +23,6 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; - /* Fix for growing textarea width when wrapper padding is 0 */ --_ui5_textarea_inner_width: 100%; } diff --git a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css index 3590773732cd..143ec7eed818 100644 --- a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css @@ -23,7 +23,6 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5625rem; --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; - /* Fix for growing textarea width when wrapper padding is 0 */ --_ui5_textarea_inner_width: 100%; } From 15205a5907f45ffdad0211d7217c7263f9d11b8b Mon Sep 17 00:00:00 2001 From: Deshev Date: Fri, 5 Sep 2025 22:05:28 +0300 Subject: [PATCH 3/4] fix(ui5-textarea): adjust width in high contrast themes lint --- packages/main/src/themes/base/TextArea-parameters.css | 2 +- .../main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css | 2 +- .../main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css | 4 ++-- packages/main/src/themes/sap_horizon/TextArea-parameters.css | 2 +- .../main/src/themes/sap_horizon_dark/TextArea-parameters.css | 2 +- .../main/src/themes/sap_horizon_hcb/TextArea-parameters.css | 2 +- .../main/src/themes/sap_horizon_hcw/TextArea-parameters.css | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/main/src/themes/base/TextArea-parameters.css b/packages/main/src/themes/base/TextArea-parameters.css index bf0307adc2f1..ce3f11c15cbb 100644 --- a/packages/main/src/themes/base/TextArea-parameters.css +++ b/packages/main/src/themes/base/TextArea-parameters.css @@ -61,4 +61,4 @@ --_ui5_textarea_padding_bottom_information: 0.0625rem; --_ui5_textarea_margin: 0.1875rem 0; --_ui5_textarea_min_height: 1.625rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css index 5e3ddd617e31..28b51a3ceef4 100644 --- a/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcb/TextArea-parameters.css @@ -36,4 +36,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css index b8315738c64c..c570070c2015 100644 --- a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css @@ -21,7 +21,7 @@ --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; --_ui5_textarea_inner_width: 100%; } - +я [data-ui5-compact-size], .ui5-content-density-compact, .sapUiSizeCompact { @@ -36,4 +36,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_horizon/TextArea-parameters.css b/packages/main/src/themes/sap_horizon/TextArea-parameters.css index 0b14393592d7..c71e7000e1ca 100644 --- a/packages/main/src/themes/sap_horizon/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon/TextArea-parameters.css @@ -47,4 +47,4 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css index 5b0097fcc086..00169222898a 100644 --- a/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css @@ -47,4 +47,4 @@ --_ui5_textarea_padding_right_and_left: 0.5rem; --_ui5_textarea_padding_right_and_left_error_warning: 0.5rem; --_ui5_textarea_padding_right_and_left_information: 0.5rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css index 01d9625cba56..e8df3ac6501e 100644 --- a/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcb/TextArea-parameters.css @@ -40,4 +40,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} +} \ No newline at end of file diff --git a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css index 143ec7eed818..7d6ec018ca49 100644 --- a/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_horizon_hcw/TextArea-parameters.css @@ -40,4 +40,4 @@ --_ui5_textarea_padding_right_and_left: 0.375rem; --_ui5_textarea_padding_right_and_left_information: 0.4375rem; --_ui5_textarea_padding_right_and_left_readonly: 0.375rem; -} +} \ No newline at end of file From 4f338e80682d2f77d0c356fd726f799e522d189d Mon Sep 17 00:00:00 2001 From: Deshev Date: Fri, 5 Sep 2025 22:09:48 +0300 Subject: [PATCH 4/4] fix(ui5-textarea): adjust width in high contrast themes lint --- .../main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css index c570070c2015..2b7d1e347381 100644 --- a/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css +++ b/packages/main/src/themes/sap_fiori_3_hcw/TextArea-parameters.css @@ -21,7 +21,7 @@ --_ui5_textarea_padding_right_and_left_readonly: 0.5rem; --_ui5_textarea_inner_width: 100%; } -я + [data-ui5-compact-size], .ui5-content-density-compact, .sapUiSizeCompact {