From 4af7fe9cdabda300934c2de0740d08574733d26d Mon Sep 17 00:00:00 2001 From: Konstantin Gogov Date: Thu, 6 Nov 2025 14:46:48 +0200 Subject: [PATCH 1/2] fix(ui5-dynamic-page): update header action button tooltip text Update message bundle to use "Collapse Header" instead of "Snap Header" for better UX consistency. Fixes #12617 --- packages/fiori/cypress/specs/DynamicPage.cy.tsx | 4 ++-- packages/fiori/src/i18n/messagebundle.properties | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/fiori/cypress/specs/DynamicPage.cy.tsx b/packages/fiori/cypress/specs/DynamicPage.cy.tsx index 4f20216a9020..437712e5c927 100644 --- a/packages/fiori/cypress/specs/DynamicPage.cy.tsx +++ b/packages/fiori/cypress/specs/DynamicPage.cy.tsx @@ -957,8 +957,8 @@ describe("ARIA attributes", () => { .find("[ui5-dynamic-page-header-actions]") .shadow() .find("[ui5-button].ui5-dynamic-page-header-action-expand") - .should("have.prop", "accessibleName", "Snap Header") - .should("have.prop", "tooltip", "Snap Header"); + .should("have.prop", "accessibleName", "Collapse Header") + .should("have.prop", "tooltip", "Collapse Header"); cy.get("[ui5-dynamic-page]") .shadow() diff --git a/packages/fiori/src/i18n/messagebundle.properties b/packages/fiori/src/i18n/messagebundle.properties index bfbdaf2e90a9..55e511484653 100644 --- a/packages/fiori/src/i18n/messagebundle.properties +++ b/packages/fiori/src/i18n/messagebundle.properties @@ -18,7 +18,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header #XACT: Aria label for the button that snaps the header -DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header +DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header #XACT: Aria label for the button that pins the header DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header From 5261e64451f8389d1a173ec528b7d664b4665687 Mon Sep 17 00:00:00 2001 From: Konstantin Gogov Date: Thu, 6 Nov 2025 15:00:52 +0200 Subject: [PATCH 2/2] fix(ui5-dynamic-page): fix failing tests due to tooltip text update --- packages/fiori/src/i18n/messagebundle_en.properties | 2 +- packages/fiori/src/i18n/messagebundle_en_GB.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/fiori/src/i18n/messagebundle_en.properties b/packages/fiori/src/i18n/messagebundle_en.properties index 9094119d88a6..2e12d8751b99 100644 --- a/packages/fiori/src/i18n/messagebundle_en.properties +++ b/packages/fiori/src/i18n/messagebundle_en.properties @@ -10,7 +10,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header -DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header +DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header diff --git a/packages/fiori/src/i18n/messagebundle_en_GB.properties b/packages/fiori/src/i18n/messagebundle_en_GB.properties index bcf8b2d2e6d7..fd1942c3a4d0 100644 --- a/packages/fiori/src/i18n/messagebundle_en_GB.properties +++ b/packages/fiori/src/i18n/messagebundle_en_GB.properties @@ -10,7 +10,7 @@ DYNAMIC_PAGE_ARIA_LABEL_SNAPPED_HEADER=Header Snapped DYNAMIC_PAGE_ARIA_LABEL_EXPAND_HEADER=Expand Header -DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Snap Header +DYNAMIC_PAGE_ARIA_LABEL_SNAP_HEADER=Collapse Header DYNAMIC_PAGE_ARIA_LABEL_PIN_HEADER=Pin Header