From a273c038e685b9c796c0b520bfaf952de1cdbfe5 Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Fri, 19 Sep 2025 18:22:10 +0300 Subject: [PATCH 1/3] fix(ui5-select): nVDA announcement fixed --- packages/main/src/Select.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/Select.ts b/packages/main/src/Select.ts index c310e5f538e9..6f6618b3b91c 100644 --- a/packages/main/src/Select.ts +++ b/packages/main/src/Select.ts @@ -1061,7 +1061,7 @@ class Select extends UI5Element implements IFormInputElement { if (this.focused && this._currentlySelectedOption) { text = `${this._currentlySelectedOption.textContent as string} ${this._isPickerOpen ? itemPositionText : ""}`; - announce(text, InvisibleMessageMode.Polite); + announce(text, InvisibleMessageMode.Assertive); } } From 584bd83d70b1d6eb47725d4c7ec06de5602579fe Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Thu, 20 Nov 2025 15:43:47 +0200 Subject: [PATCH 2/3] fix(ui5-select): nvda announcement fix for selected item --- packages/main/src/Select.ts | 8 ++++++++ packages/main/src/SelectTemplate.tsx | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/main/src/Select.ts b/packages/main/src/Select.ts index fe7d4616cf22..fef1f5bb15e7 100644 --- a/packages/main/src/Select.ts +++ b/packages/main/src/Select.ts @@ -1050,6 +1050,14 @@ class Select extends UI5Element implements IFormInputElement { && this.responsivePopover.open) ? -1 : 0; } + get activeDescendant() { + return this._isPickerOpen ? this.activeDescendantId : ""; + } + + get activeDescendantId() { + return `${this.id}-activeDescendant`; + } + /** * This method is relevant for sap_horizon theme only */ diff --git a/packages/main/src/SelectTemplate.tsx b/packages/main/src/SelectTemplate.tsx index c0ed1fb24c7c..035327905395 100644 --- a/packages/main/src/SelectTemplate.tsx +++ b/packages/main/src/SelectTemplate.tsx @@ -43,10 +43,11 @@ export default function SelectTemplate(this: Select) { onFocusIn={this._onfocusin} onFocusOut={this._onfocusout} aria-controls={this.responsivePopoverId} + aria-activedescendant={this.activeDescendant} > {this.hasCustomLabel ? - : this.text + : {this.text} } From 53f083429d269c94655125766213c6c5564fa0f1 Mon Sep 17 00:00:00 2001 From: PetyaMarkovaBogdanova Date: Thu, 20 Nov 2025 16:08:57 +0200 Subject: [PATCH 3/3] fix(ui5-select): nvda announcement fix for selected item --- packages/main/src/Select.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/main/src/Select.ts b/packages/main/src/Select.ts index ed5aba9e001c..fef1f5bb15e7 100644 --- a/packages/main/src/Select.ts +++ b/packages/main/src/Select.ts @@ -1141,7 +1141,7 @@ class Select extends UI5Element implements IFormInputElement { if (this.focused && this._currentlySelectedOption) { text = `${this._currentlySelectedOption.textContent as string} ${this._isPickerOpen ? itemPositionText : ""}`; - announce(text, InvisibleMessageMode.Assertive); + announce(text, InvisibleMessageMode.Polite); } }