This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Remove autocomplete functionality #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intended to allow steps which have no fields, and so do not need to do anything on POST to simply link through to subsequent steps and save a round trip. However, this is causing other steps which *do* need to perform actions on POST, and should not autocomplete, to incorrectly mark themselves complete. In particular "check answers" pages skipping directly to confirmation pages without submitting in some edge cases. Since this behaviour is not known to be currently used, and is simple to implement as an extended behaviour, remove it.
easternbloc
approved these changes
Feb 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to allow steps which have no fields, and so do not need to do anything on POST to simply link through to subsequent steps and save a round trip.
However, this is causing other steps which do need to perform actions on POST, and should not autocomplete, to incorrectly mark themselves complete. In particular "check answers" pages skipping directly to confirmation pages without submitting in some edge cases.
Since this behaviour is not known to be currently used, and is simple to implement as an extended behaviour, remove it.