-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add callback so we can do pruning and check for nan
values.
#327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nan
values.nan
values.
nan
values.nan
values.
Do you have any questions about this PR? |
Hi, Currently I try to think about if the callback could return something that influences the training, for example, stopping the training or what so ever.
Also, it would be an option to add the callback to the evaluators instead of to the fit function. This would have the advantage that each evaluator could have it's own callback, which might (or might not) be quite useful if you evaluate your model on more than dev dataset. It would be great to learn more how you are using this callback for hyperparameter tuning. |
f8b3bb2
to
efa517d
Compare
efa517d
to
c28ac77
Compare
I use it in optuna for automated hyperparameter optimization. Optuna has something called pruning where I noticed that some hyperparameter combinations return It looks like this:
See more here: https://optuna.readthedocs.io/en/stable/tutorial/pruning.html |
Thanks for the PR. Merged it and it will be part of the next release (0.3.6) |
I added a callback function. This way I can implement pruning and check for
nan
values when doing automated hyperparameter optimization. What do you think?Some docstrings are still missing so if you agree I would complete the PR.
Thanks
Philip