Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always store best_score #439

Merged
merged 1 commit into from Oct 2, 2020
Merged

Always store best_score #439

merged 1 commit into from Oct 2, 2020

Conversation

PhilipMay
Copy link
Contributor

This is just a small fix.

  • the best_score during training had been stored only when save_best_model was true
  • now best_score is always stored

@PhilipMay
Always store best_score
e6852b4 
- the best_score during training had been stored only when save_best_model was true
- now best_score is always stored
@PhilipMay
Copy link
Contributor Author

Just wanted to bump this. @nreimers

@nreimers nreimers merged commit dc84bb7 into UKPLab:master Oct 2, 2020
@nreimers
Copy link
Member

nreimers commented Oct 2, 2020

Sorry for the delay. Thanks for the PR, it is merged :)

@PhilipMay
Copy link
Contributor Author

Yay! ;-)

@ReySadeghi
Copy link

Hi,
save best model by default is based on cosine_average_precision?

@nreimers
Copy link
Member

@ReySadeghi
It is based on what the evaluator, passed to the fit method, returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PhilipMay @nreimers @ReySadeghi