Add GitHub Actions for this pre-lab #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is essentially a copy of the `disemvowel` actions from the next lab, with the relevant name changes, etc.
I'm not 100% sure when/why we do/don't need the `-pthread` flag, but the code didn't compile on the VM used for the testing, and I'm guessing that removing that flag is the problem. You don't seem to need it in our lab, though. Maybe the issue is different C++ compilers, i.e., GNU vs CLang?
All three GitHub Actions had both `push` and `pull-request` as triggers, which meant that we run all the tests twice whenever we pushed to a PR. That just seems wasteful, so I removed the `on pull-request` trigger.
This documents the existence of GitHub Actions and the status indicators. I still need to sort out the badge material.
I also added a note about the badges in the README.
One of the badge URLs still had `disemvowel` in it (copy-paste error). Hopefully this will fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a copy of the
disemvowelactions from the next lab, with the relevant name changes, etc.I also added the badges here.
The two
valgrindchecks deliberately fail since those are memory issues the students are supposed to fix in this lab. That also means that those two badges are red instead of green. Presumably all the checks and badges will be happy when the students turn in their labs.Closes #6