From 2bcaf5dc57cac2c3d50275b0cd11279d11499884 Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:30:48 +0200 Subject: [PATCH 1/7] feat: add cppcheck to the pipeline --- .github/workflows/cpp-check.yml | 32 ++++++++++++++++++++++++++++++++ .gitignore | 4 +++- exercises/sum.cpp | 4 ++++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 .github/workflows/cpp-check.yml diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml new file mode 100644 index 00000000..5a6576e1 --- /dev/null +++ b/.github/workflows/cpp-check.yml @@ -0,0 +1,32 @@ +name: cpp-check +on: + push: + branches: + - "main" + paths: + - "!README.md" + pull_request: + paths: + - "!README.md" + +jobs: + cpp-check: + strategy: + fail-fast: false + runs-on: [ubuntu-22.04] + name: cpp check + steps: + - uses: actions/checkout@v2 + - name: Install dependencies + run: | + sudo apt update -y + sudo apt install -y cppcheck + - name: cpp check + run: | + cppcheck --force --inline-suppr --suppressions-list=./.suppress.cppcheck --output-file=report.txt \ + exercises/ + + if [ -s report.txt ]; then # if file is not empty + cat report.txt + exit 1 # let github action fails + fi diff --git a/.gitignore b/.gitignore index dbe9c82b..75e1380f 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,3 @@ -.vscode/ \ No newline at end of file +.vscode/ +report.txt + diff --git a/exercises/sum.cpp b/exercises/sum.cpp index 0dcca937..984cfb1b 100644 --- a/exercises/sum.cpp +++ b/exercises/sum.cpp @@ -6,3 +6,7 @@ Insert the second number: 2 Sum: 3 */ +int main() { + int x; + cout << x << endl; +} From d9810eeafc675fd771937a3d2a57ea6f42c124e4 Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:32:46 +0200 Subject: [PATCH 2/7] chore: update cpp check ci --- .github/workflows/cpp-check.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index 5a6576e1..f6b3c508 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -1,10 +1,5 @@ name: cpp-check on: - push: - branches: - - "main" - paths: - - "!README.md" pull_request: paths: - "!README.md" @@ -23,7 +18,7 @@ jobs: sudo apt install -y cppcheck - name: cpp check run: | - cppcheck --force --inline-suppr --suppressions-list=./.suppress.cppcheck --output-file=report.txt \ + cppcheck --force --inline-suppr --output-file=report.txt \ exercises/ if [ -s report.txt ]; then # if file is not empty From fd9920584e00b54309ada9388f28c33d8a2c48fe Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:34:07 +0200 Subject: [PATCH 3/7] chore: check cpp check pipeline --- .github/workflows/cpp-check.yml | 7 +++++++ exercises/sum.cpp | 3 +++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index f6b3c508..fe2e42be 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -1,6 +1,13 @@ name: cpp-check on: + push: + branches: + - "main" + paths: + - "!README.md" pull_request: + branches: + - "main" paths: - "!README.md" diff --git a/exercises/sum.cpp b/exercises/sum.cpp index 984cfb1b..7d29f2fa 100644 --- a/exercises/sum.cpp +++ b/exercises/sum.cpp @@ -6,6 +6,9 @@ Insert the second number: 2 Sum: 3 */ +#include +using namespace std; + int main() { int x; cout << x << endl; From 8b3fb9481f025aa4852e07282a06c71e9ff3dbec Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:35:27 +0200 Subject: [PATCH 4/7] fix: cpp check --- .github/workflows/cpp-check.yml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index fe2e42be..ee482684 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -25,10 +25,8 @@ jobs: sudo apt install -y cppcheck - name: cpp check run: | - cppcheck --force --inline-suppr --output-file=report.txt \ - exercises/ - - if [ -s report.txt ]; then # if file is not empty - cat report.txt - exit 1 # let github action fails - fi + cppcheck --force --inline-suppr --output-file=report.txt exercises/ + if [ -s report.txt ]; then # if file is not empty + cat report.txt + exit 1 # let github action fails + fi From bdbb0bb1c4094c742f7af040a83aa50d387dab13 Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:36:14 +0200 Subject: [PATCH 5/7] wip --- .github/workflows/cpp-check.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index ee482684..4b142b2b 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -1,15 +1,7 @@ name: cpp-check on: push: - branches: - - "main" - paths: - - "!README.md" pull_request: - branches: - - "main" - paths: - - "!README.md" jobs: cpp-check: From 1e23c22186a5e43775cb7fdb3d7f43cee675d9d0 Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:37:03 +0200 Subject: [PATCH 6/7] wip --- .github/workflows/cpp-check.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index 4b142b2b..bee94ae5 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -1,7 +1,11 @@ name: cpp-check on: push: + branches: + - "main" pull_request: + branches: + - "main" jobs: cpp-check: From f72095090106f2035e13b6ecb4d0537022d2fcfc Mon Sep 17 00:00:00 2001 From: Helias Date: Tue, 17 Oct 2023 20:42:02 +0200 Subject: [PATCH 7/7] fix: pipeline --- .github/workflows/ci.yml | 5 +---- .github/workflows/cpp-check.yml | 4 +--- exercises/sum.cpp | 7 ------- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9593958a..d7ea706c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,9 +1,6 @@ name: CI on: - push: - branches: - - '**' pull_request: branches: [main] @@ -15,4 +12,4 @@ jobs: - name: install g++ run: sudo apt install -y g++ - name: check build - run: source ./compile.sh \ No newline at end of file + run: source ./compile.sh diff --git a/.github/workflows/cpp-check.yml b/.github/workflows/cpp-check.yml index bee94ae5..d513201c 100644 --- a/.github/workflows/cpp-check.yml +++ b/.github/workflows/cpp-check.yml @@ -1,8 +1,6 @@ name: cpp-check + on: - push: - branches: - - "main" pull_request: branches: - "main" diff --git a/exercises/sum.cpp b/exercises/sum.cpp index 7d29f2fa..0dcca937 100644 --- a/exercises/sum.cpp +++ b/exercises/sum.cpp @@ -6,10 +6,3 @@ Insert the second number: 2 Sum: 3 */ -#include -using namespace std; - -int main() { - int x; - cout << x << endl; -}