Skip to content
This repository has been archived by the owner on Jan 28, 2020. It is now read-only.

Replace newly-added apr_uintptr_t with apr_size_t, for apr < 1.4.0 #19

Merged
merged 1 commit into from Mar 26, 2015

Conversation

alexmv
Copy link

@alexmv alexmv commented Mar 25, 2015

As per e6f6021; apr_uintptr_t was added in apr 1.4.0. Switching to
apt_size_t restores compatibility with earlier versions of apr.

Signed-off-by: Alex Vandiver alex@chmrr.net

@olavmrk
Copy link
Contributor

olavmrk commented Mar 26, 2015

Hi,

a minor clarification: apr_uintptr_t has been present since 1.3.0:
https://github.com/apache/apr/blob/1.3.0/include/apr.h.in#L291

Before I apply this, could you elaborate a bit about which distribution still ships with APR older than 1.3.0?

As per e6f6021; apr_uintptr_t was added in apr 1.3.0.  Switching to
apt_size_t restores compatibility with earlier versions of apr.

Signed-off-by: Alex Vandiver <alex@chmrr.net>
@alexmv
Copy link
Author

alexmv commented Mar 26, 2015

Ah -- git blame in apr only found me the 1.4.0 version of that commit. I've amended the commit message accordingly.

Sadly, RHEL5 is still in use in some places, and ships APR 1.2.7. 😕

olavmrk added a commit that referenced this pull request Mar 26, 2015
Replace newly-added apr_uintptr_t with apr_size_t, for apr < 1.3.0
@olavmrk olavmrk merged commit 4b4c63e into Uninett:master Mar 26, 2015
@olavmrk
Copy link
Contributor

olavmrk commented Mar 26, 2015

OK, thanks for the clarification. I have now merged the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants