Redirect to the members page if the membership was removed #53

Merged
merged 3 commits into from Mar 13, 2014

Conversation

Projects
None yet
2 participants
@mfairchild365
Contributor

mfairchild365 commented Mar 13, 2014

Fixes #40

@@ -215,13 +215,13 @@ public function handlePost($get, $post, $files)
$notice = new FlashBagMessage(FlashBagMessage::TYPE_SUCCESS, 'Roles were added for ' . $this->join_user->getName());

This comment has been minimized.

Show comment Hide comment
@kabel

kabel Mar 13, 2014

Contributor

This success message is still incorrect for a role removal.

@kabel

kabel Mar 13, 2014

Contributor

This success message is still incorrect for a role removal.

This comment has been minimized.

Show comment Hide comment
@mfairchild365

mfairchild365 Mar 13, 2014

Contributor

Fixed in mfairchild365/site_master@460c1e0

Unless you have a better suggestion...

@mfairchild365

mfairchild365 Mar 13, 2014

Contributor

Fixed in mfairchild365/site_master@460c1e0

Unless you have a better suggestion...

This comment has been minimized.

Show comment Hide comment
@kabel

kabel Mar 13, 2014

Contributor

In a perfect world the message would be different if !$this->join_user_membership (dropped member)

@kabel

kabel Mar 13, 2014

Contributor

In a perfect world the message would be different if !$this->join_user_membership (dropped member)

This comment has been minimized.

Show comment Hide comment

kabel added a commit that referenced this pull request Mar 13, 2014

Merge pull request #53 from mfairchild365/issue-40
Redirect to the members page if the membership was removed

@kabel kabel merged commit 4500dff into UNLSiteMaster:master Mar 13, 2014

1 check was pending

default The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment