Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create !parking #443

Merged
merged 4 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@bradleysigma
Copy link
Contributor

commented Jun 3, 2019

Creates !parking, which lists casual parking available, and !parking all, which lists casual and permit parking available.
image
Implements parking.js from unimplemented_commands.

@jdcaperon

This comment has been minimized.

Copy link
Collaborator

commented Jun 3, 2019

If you put the parking text in triple quotes does it condense the information a bit better? Just a formatting recommendation.

@bradleysigma

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

If you put the parking text in triple quotes does it condense the information a bit better? Just a formatting recommendation.

Which text (what line[s])?

@nicklambourne
Copy link
Member

left a comment

Looks good to me, just a few nits.

Don't know if you remember the old ~parking, but it made use of colour, spacing etc to improve the user experience. Happy to approve as is with the nits fixed and leave making it look fancy to someone else (probs just chuck an issue up).

Show resolved Hide resolved uqcsbot/scripts/parking.py Outdated
Show resolved Hide resolved uqcsbot/scripts/parking.py Outdated
Show resolved Hide resolved uqcsbot/scripts/parking.py Outdated
Update parking.py
As per @nicklambourne's requests.

@bradleysigma bradleysigma requested a review from nicklambourne Jun 7, 2019

@nicklambourne nicklambourne merged commit 18cb1b1 into master Jun 7, 2019

1 check passed

Jenkins 55 tests run, 0 skipped, 0 failed.
Details

@bradleysigma bradleysigma deleted the Parking branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.