Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojify #446

Merged
merged 3 commits into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@bradleysigma
Copy link
Contributor

commented Jun 8, 2019

Long messages are now no longer split in the middle of an emoji.
(Also, :office_excel: is now an x, not an e.)

@nicklambourne
Copy link
Member

left a comment

Can you add a total length cap at something reasonable as well?

@bradleysigma

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Can you add a total length cap at something reasonable as well?

Is 3991 characters reasonable? If so, done.

@nicklambourne

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

Can you add a total length cap at something reasonable as well?

Is 3991 characters reasonable? If so, done.

Um, no. 300-500 absolute tops.

@bradleysigma

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Now limits to one message (4000 characters) from UQCSbot, with ellipsis. Also preserves linebreaks.

@bradleysigma bradleysigma requested a review from nicklambourne Jun 9, 2019

@nicklambourne nicklambourne merged commit fd960cf into master Jun 18, 2019

1 check passed

Jenkins 57 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.