Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsdue fix 050519 #474

Merged
merged 4 commits into from Aug 5, 2019

Conversation

@Guthers
Copy link
Collaborator

commented Aug 5, 2019

Fixes !whatsdue and !ecp. They broke because you now need to supply a user agent when making a request to the site.

I also added some more error handling to stop it from hanging as often.

Closes #473 and closes #472

@Guthers Guthers requested a review from nicklambourne Aug 5, 2019

@jdcaperon

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

Jenkins is failing due to linting errors, please rectify :)

uqcsbot/utils/uq_course_utils.py:77:62: E252 missing whitespace around parameter equals
uqcsbot/utils/uq_course_utils.py:77:63: E252 missing whitespace around parameter equals
uqcsbot/utils/uq_course_utils.py:86:70: W291 trailing whitespace
uqcsbot/utils/uq_course_utils.py:87:80: W291 trailing whitespace

Guthers added some commits Aug 5, 2019

@nicklambourne nicklambourne merged commit 6e33e06 into master Aug 5, 2019

1 check passed

Jenkins 73 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.