Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UQCSBot: Ressurection #505

Merged
merged 10 commits into from Jan 11, 2020
Merged

Conversation

@TRManderson
Copy link
Member

TRManderson commented Jan 3, 2020

This is a cleaned up version of my PR #503, which also includes some extra stuff like a partial fix for #493 (to be implemented separately per script). There's a lot going on soz. This is needed for medium term UQCSBot stability.

TRManderson added 8 commits Dec 27, 2019
Provided a function to automate replying to the correct location based on the OG message
Command handler is by far the most used, so by making it async-first we should hopefully improve performance
@TRManderson TRManderson force-pushed the TRManderson:slackclient-v2 branch from db38da8 to d3b2177 Jan 3, 2020
@TRManderson

This comment has been minimized.

Copy link
Member Author

TRManderson commented Jan 3, 2020

I've verified dev mode still works without further coordination effort RE user tokens, so that's nice

Copy link
Member

nicklambourne left a comment

lgtm overall (fab, actually), but dev mode is broken with current setup:

No longer appear to be able to run using the python3 -m uqcsbot --dev command.

Screen Shot 2020-01-10 at 8 44 30 pm

Though works once the proper env variable is set.

We either need to update the docs with new instructions on the need to add the SLACK_USER_TOKEN environment variable (and where to get it from w/ link) or (preferably) provide the token like the BOT_TOKENS (if safe to do so).

Copy link
Collaborator

jdcaperon left a comment

LGTM as written 👍 really nice implementation, thanks for resuscitating the bot

the test environment would be a nice to have for sure but better to get the bot back

@TRManderson TRManderson merged commit 1f79987 into UQComputingSociety:master Jan 11, 2020
1 check passed
1 check passed
Jenkins 83 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.