Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LID Models Hang in SWMM 5.1.013 but works fine in SWMM 5.1.02 #16

Closed
dickinsonre opened this Issue Mar 24, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@dickinsonre
Copy link

dickinsonre commented Mar 24, 2019

A little history on this particular model. It stared live as a USGS Nurp Study in Dade County, Florida. I made a SWMM4 file for it and it has been the subject of many thesis. It was converted to SWMM5 many years ago and i use it a lot in InfoSWMM for water quality with hydrology. This model works in InfoSWMM, all SWMM 5 versions before and including SWMM 5.1.012 but hangs with no error message in SWMM 5.1.013. I have tried to find the issue but cannot.
Note: the file had to be changed to .txt from .inp for Github roles. Further note - this will work in SWMM 5.1.103 if you delete the LID Usage Tables. LID Controls do not have to deleted.

2015_Simple_Yet_Interesting_Network_InfoSWMM_13.txt

@dickinsonre dickinsonre changed the title LID Models Hang in SWMM 5.1.013 but work find in SWMM 5.1.02 LID Models Hang in SWMM 5.1.013 but work fine in SWMM 5.1.02 Mar 24, 2019

@dickinsonre dickinsonre changed the title LID Models Hang in SWMM 5.1.013 but work fine in SWMM 5.1.02 LID Models Hang in SWMM 5.1.013 but works fine in SWMM 5.1.02 Mar 24, 2019

@michaeltryby michaeltryby added the bug label Mar 24, 2019

@dickinsonre

This comment has been minimized.

Copy link
Author

dickinsonre commented Mar 29, 2019

This is actually the same issue as LID "Return all outflow to pervious area" dead loop #10

and the suggested code changes by @michaeltryby work and the models do not hang

@dickinsonre

This comment has been minimized.

Copy link
Author

dickinsonre commented Mar 29, 2019

The code from Michael

         //... skip LID unit if it sends its drain flow onto
        //    its subcatchment's pervious area
        //   if (lidUnit->toPerv) continue;
		if (lidUnit->toPerv)
		{
		### 	**// process next LID unit in the group
			lidList = lidList->nextLidUnit;
			continue;**
		}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.