Add Phoebe alias and 1 USEEIO model #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-young
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
On specifying the use of useeior v1.7.1 for v2.5.1 models, just clarifying that v1.7.0 should also be fine (we had just already published the patch by the time we made the fix to the v2.5.1 models). All of which is to say, I'm generally of the impression that changes in data or fixes to the package that would impact a national model should in most cases be a minor update and not a patch update.
|
Oops i was about to click close and I saw it was merged. @bl-young we will need to update the GHG ext info for phoebe after its revised and accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Phoebe model will be used for the new SEFs