Set nml with vectors #245
Merged
Set nml with vectors #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @farrellkj2. I think this fixes the errors you were having. |
|
@jsta can the test failures be fixed? |
jordansread
reviewed
Jan 31, 2019
| # read character vectors | ||
| glm_nml <- read_nml() | ||
| glm_nml <- set_nml(glm_nml, arg_list = list( | ||
| 'inflow_fl' = c("yahara.csv", "yahara2.csv"))) |
There was a problem hiding this comment.
Can you also add a small test to verify that setting it the old way has an identical result? So that we stay backwards compatible with this change. I expect it is the same, but better to have a test.
There was a problem hiding this comment.
Ok, I think the new test I've added checks for this.
|
One more request, please increment the minor version (to 0.15.0 I think) and add yourself as a contributor in the DESCRIPTION file unless you would prefer not to be named @jsta |
|
I think this is good to go @jread-usgs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like nml character fields with more than one value (i.e. vectors) are expected to be written ("collapsed") as a single comma separated string. However,
set_nmlwrites them as a vector of strings.See MWE at: https://gist.github.com/jsta/2c82af2399bce2ead477727b3e1e2532
This PR enforces collapsing for character fields passed to
set_nml.