New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veg_hist code in 4.2 lacks an update #306

Closed
tbohn opened this Issue Nov 13, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tbohn
Collaborator

tbohn commented Nov 13, 2015

I have discovered that my original implementation of the veg_hist feature in release 4.2 was missing a modification I subsequently made in my private version but forgot to add to GIT. This modification results in minor changes to soil evaporation magnitudes but is necessary to make 4.2 match the results and description in my manuscript. Changes are confined to two files: arno_evap.c and func_surf_energy_bal.c.

I'd like to add this as a hotfix to 4.2. Would that be OK?

@tbohn

This comment has been minimized.

Show comment
Hide comment
@tbohn

tbohn Nov 15, 2015

Collaborator

The code changes for this are ready on my own branch off master, and I can make a pull request, but I don't know which official branch to make the pull request to.

Collaborator

tbohn commented Nov 15, 2015

The code changes for this are ready on my own branch off master, and I can make a pull request, but I don't know which official branch to make the pull request to.

@jhamman

This comment has been minimized.

Show comment
Hide comment
@jhamman

jhamman Nov 16, 2015

Member

I think 4.2.c is fine. I can backport to 5. Make a PR against master.

Member

jhamman commented Nov 16, 2015

I think 4.2.c is fine. I can backport to 5. Make a PR against master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment