New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water balance error in lake model #308

Closed
tbohn opened this Issue Nov 17, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tbohn
Collaborator

tbohn commented Nov 17, 2015

The lake model in release 4.2 is exhibiting water balance errors. Currently investigating to find the source of the problem.

So far, I have found at least one part of the problem: the variable out_prec, used only for reporting precipitation for output, was not being updated correctly in full_energy.c. This only affects the water balance check in put_data.c (as well as making the output precipitation not equal the input precipitation). This is easy to fix. However, after fixing this, there are still water balance errors, which I am investigating now.

@tbohn

This comment has been minimized.

Show comment
Hide comment
@tbohn

tbohn Nov 17, 2015

Collaborator

As it turns out, the OUT_PREC bug is the only code bug. The other issue was caused by a bad parameter value, for which I have added some extra validation in read_lakeparam.c.

Collaborator

tbohn commented Nov 17, 2015

As it turns out, the OUT_PREC bug is the only code bug. The other issue was caused by a bad parameter value, for which I have added some extra validation in read_lakeparam.c.

@tbohn

This comment has been minimized.

Show comment
Hide comment
@tbohn

tbohn Dec 8, 2015

Collaborator

@jhamman this issue can be closed since you've merged pull request #316

Collaborator

tbohn commented Dec 8, 2015

@jhamman this issue can be closed since you've merged pull request #316

@jhamman jhamman closed this Dec 8, 2015

@jhamman jhamman added this to the 4.2.c milestone Dec 8, 2015

@jhamman jhamman added the bug label Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment