New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for soil layer temperatures when soil thermal nodes do not reach bottom of soil column. #467

Merged
merged 4 commits into from Apr 11, 2016

Conversation

Projects
None yet
3 participants
@tbohn
Collaborator

tbohn commented Apr 10, 2016

This change is relatively minor. This addresses #377, at least for 5.0. The error in #377 was reported for 4.2.c, even when FROZEN_SOIL was FALSE. I was not able to reproduce this error in 5.0 unless FROZEN_SOIL was TRUE. What happens is: if the bottom of the lowest soil layer is deeper than the soil thermal damping depth (dp), and if FROZEN_SOIL is true, then when the model attempts to estimate layer ice content via estimate_layer_ice_content(), it encounters a layer for which soil thermal nodes do not cover the entire layer. In this case, VIC would abort.

The thing is, if the log_err() call were removed, the logic in estimate_layer_ice_content() would actually work fine: the temperature of the deepest node would be used for all depths below it. So, my fix here was simply to remove the log_err() call.

closes #377

Show outdated Hide outdated vic/vic_run/src/soil_conduction.c Outdated

@bartnijssen bartnijssen merged commit 78a7ff1 into UW-Hydro:develop Apr 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tbohn tbohn deleted the tbohn:fix/soil_thermal_nodes branch May 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment