New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in writing statefile for 2-d lat/lon dimensions #652

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
4 participants
@dgergel
Contributor

dgergel commented Nov 11, 2016

2-D lats/lons were being written to state file as fill values rather than actual lats/lons, this PR fixes that.

fixed bug in writing statefile for 2-d lat/lon dimensions; previously…
… the 2-D lats/lons were written as fill values to the state file rather than lats/lons
@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Nov 15, 2016

Contributor

cc @yixinmao, @jhamman for review.

Contributor

dgergel commented Nov 15, 2016

cc @yixinmao, @jhamman for review.

@jhamman

Looks good to me. Can you add a note to the change log?

@yixinmao

This comment has been minimized.

Show comment
Hide comment
@yixinmao

yixinmao Nov 16, 2016

Contributor

@dgergel looks good to me.

Contributor

yixinmao commented Nov 16, 2016

@dgergel looks good to me.

@bartnijssen bartnijssen merged commit 8ef7a20 into UW-Hydro:hotfix/5.0.1 Dec 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dgergel added a commit to dgergel/VIC that referenced this pull request Dec 29, 2016

bartnijssen added a commit that referenced this pull request Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment