New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve floating point comparisons in vic_init.c #701

Merged
merged 13 commits into from Aug 8, 2017

Conversation

Projects
None yet
4 participants
@jhamman
Member

jhamman commented Mar 15, 2017

A few cleanup items.

  • closes #xxx
  • tests passed
  • ran uncrustify prior to final commit
  • ReleaseNotes entry
@jhamman

This comment has been minimized.

Show comment
Hide comment
@jhamman

jhamman Apr 28, 2017

Member

@UW-Hydro/vic-developers - this is ready for another review.

Member

jhamman commented Apr 28, 2017

@UW-Hydro/vic-developers - this is ready for another review.

@bartnijssen

I'll wait with further review till it's resolved that this is what we want

Show outdated Hide outdated vic/drivers/shared_all/src/calc_root_fraction.c Outdated
Show outdated Hide outdated vic/drivers/shared_all/src/calc_root_fraction.c Outdated
Show outdated Hide outdated vic/drivers/shared_all/src/calc_root_fraction.c Outdated
Show outdated Hide outdated vic/drivers/shared_all/src/calc_root_fraction.c Outdated
@bartnijssen

Same comments as earlier. If you don't change them - just reply to the comment so I know you looked at it.

@@ -124,6 +134,7 @@ calc_root_fractions(veg_con_struct *veg_con,
}
}
else if (Zsum + Zstep > Lsum) {
zone++;

This comment has been minimized.

@jhamman

jhamman Aug 8, 2017

Member

@tbohn - can you look at the changes in this file, specifically this line?

@jhamman

jhamman Aug 8, 2017

Member

@tbohn - can you look at the changes in this file, specifically this line?

This comment has been minimized.

@tbohn

tbohn Aug 8, 2017

Collaborator

Looks good. I'm assuming you've tested this to ensure that the root fractions come out the same as before?

I wonder if there's a simpler algorithm for this function. Something to look into some day.

@tbohn

tbohn Aug 8, 2017

Collaborator

Looks good. I'm assuming you've tested this to ensure that the root fractions come out the same as before?

I wonder if there's a simpler algorithm for this function. Something to look into some day.

@jhamman

This comment has been minimized.

Show comment
Hide comment
@jhamman

jhamman Aug 8, 2017

Member

@bartnijssen - I think we're all good here. Want to take one more look?

Member

jhamman commented Aug 8, 2017

@bartnijssen - I think we're all good here. Want to take one more look?

@bartnijssen

This comment has been minimized.

Show comment
Hide comment
@bartnijssen

bartnijssen Aug 8, 2017

Member

@jhamman - review passed - just merging develop back into it since it said it was out-of-date. If the check passes I'll go ahead and merge.

Member

bartnijssen commented Aug 8, 2017

@jhamman - review passed - just merging develop back into it since it said it was out-of-date. If the check passes I'll go ahead and merge.

@bartnijssen bartnijssen merged commit abdbe35 into UW-Hydro:develop Aug 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment