New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass gridcell averaged albedo from all_vars struct to wrf #718

Merged
merged 18 commits into from Aug 3, 2017

Conversation

Projects
None yet
2 participants
@dgergel
Contributor

dgergel commented Jun 16, 2017

  • closes #xxx
  • tests passed
  • new tests added
  • science test figures
  • ran uncrustify prior to final commit
  • ReleaseNotes entry

This quick PR is a follow-up to #712 and #710 so that the cesm_put_data.c routine in the CESM driver passes gridcell-averaged albedo to WRF.

@dgergel dgergel added the CESM driver label Jun 16, 2017

@dgergel dgergel self-assigned this Jun 16, 2017

@dgergel dgergel requested review from bartnijssen and jhamman Jun 16, 2017

@jhamman

Looks good to me. @bartnijssen can merge if this makes sense to him.

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Jun 21, 2017

Contributor

We should hold off on merging this until I address the issue that @bartnijssen and I were looking at yesterday (we need to be passing weighted veg or snow albedos when shortwave is zero). I am going to see if I can do this before I leave tomorrow for vacation.

Contributor

dgergel commented Jun 21, 2017

We should hold off on merging this until I address the issue that @bartnijssen and I were looking at yesterday (we need to be passing weighted veg or snow albedos when shortwave is zero). I am going to see if I can do this before I leave tomorrow for vacation.

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Jul 18, 2017

Contributor

@jhamman and @bartnijssen this is ready for another review.

Contributor

dgergel commented Jul 18, 2017

@jhamman and @bartnijssen this is ready for another review.

@jhamman

This comment has been minimized.

Show comment
Hide comment
@jhamman

jhamman Jul 18, 2017

Member

@dgergel - can you post a few figures that demonstrate the behavior of this version of the code?

Member

jhamman commented Jul 18, 2017

@dgergel - can you post a few figures that demonstrate the behavior of this version of the code?

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Jul 18, 2017

Contributor

@jhamman I've just posted a bunch of figures in the RASM slack channel showing this.

Contributor

dgergel commented Jul 18, 2017

@jhamman I've just posted a bunch of figures in the RASM slack channel showing this.

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Aug 1, 2017

Contributor

Some figures that demonstrate the behavior of this version of the code (note that this PR includes changes to both cold start albedo and how we're calculating albedo at each time step, so I'm including figures for both):

First timestep (colorbar ranges not set so that the full ranges are clear):
VIC4
image

VIC5
image

Second timestep (VIC5 colorbar set to VIC 4 colorbar min and max):
image

Third timestep:
image

Contributor

dgergel commented Aug 1, 2017

Some figures that demonstrate the behavior of this version of the code (note that this PR includes changes to both cold start albedo and how we're calculating albedo at each time step, so I'm including figures for both):

First timestep (colorbar ranges not set so that the full ranges are clear):
VIC4
image

VIC5
image

Second timestep (VIC5 colorbar set to VIC 4 colorbar min and max):
image

Third timestep:
image

@jhamman

jhamman approved these changes Aug 3, 2017

This looks good now. You need to run uncrustify again though.

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Aug 3, 2017

Contributor

@jhamman all done. This should be ready to merge.

Contributor

dgergel commented Aug 3, 2017

@jhamman all done. This should be ready to merge.

@jhamman jhamman merged commit 1352b6d into UW-Hydro:develop Aug 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dgergel dgergel referenced this pull request Aug 24, 2017

Closed

Fix albedo averaging #690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment