New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cesm timingtables secsday columns #746

Merged
merged 5 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@dgergel
Contributor

dgergel commented Sep 4, 2017

  • closes #745
  • tests passed
  • new tests added
  • science test figures
  • ran uncrustify prior to final commit
  • ReleaseNotes entry

@dgergel dgergel self-assigned this Sep 4, 2017

@dgergel dgergel requested review from bartnijssen and jhamman Sep 4, 2017

@jhamman

jhamman approved these changes Sep 5, 2017

The logic looks good here. Can you post a timing table to show that its working?

@bartnijssen

This comment has been minimized.

Show comment
Hide comment
@bartnijssen

bartnijssen Sep 5, 2017

Member

@dgergel : Please resolve merge conflict

Member

bartnijssen commented Sep 5, 2017

@dgergel : Please resolve merge conflict

@bartnijssen

Same as @jhamman : Please post a timing table - otherwise looks good to me as well.

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Sep 5, 2017

Contributor

An timing table with this branch from a 5-day RI run:

------------------------------ VIC TIMING PROFILE ------------------------------

  Date                      : Fri Sep  1 20:44:48 2017
  Compiler                  : icc (Intel(R) C++ gcc 4.3 mode)
  Machine                   : r8i4n0
  VIC User                  : gergel
  VIC Version               : unset
  VIC GIT Version           : 5.0.1 February 1, 2017
  VIC_DRIVER                : CESM

  Global Param File         : vic.globalconfig.txt
  Domain File               : /p/work2/projects/rasm/inputdata/share/domains/domain.lnd.wr50a_ar9v4.100920.nc
  Start Date                : 1948-09-01-00000
  Stop Date                 : 1948-09-06
  Nrecs                     : 120
  Model Timestep (seconds)  : 3600
  Snow Timestep (seconds)   : 3600
  Runoff Timestep (seconds) : 3600
  Atmos Timestep (seconds)  : 3600

  MPI Processes             : 64
  OPENMP Threads            : 1
  Total pes active          : 64
  pes per node              : 72

  Overall Metrics
  ---------------
    Model Cost       : 2401.31 pe-hrs/simulated_year
    Model Throughput : 0.639651 simulated_years/day

  Timing Table:
|------------|----------------------|----------------------|----------------------|----------------------|
| Timer      | Wall Time (secs)     | CPU Time (secs)      | Wall Time (secs/day) | CPU Time (secs/day)  |
|------------|----------------------|----------------------|----------------------|----------------------|
| Init Time  |              1.12486 |                 0.52 |             0.224971 |                0.104 |
| Run Time   |              1849.18 |              1846.94 |              369.835 |              369.388 |
| Final Time |            0.0232549 |                 0.01 |           0.00465097 |                0.002 |
| Total Time |              1850.32 |              1847.47 |              370.065 |              369.494 |
|------------|----------------------|----------------------|----------------------|----------------------|
| Force Time |             0.151743 |                 0.22 |            0.0303486 |                0.044 |
| Write Time |              470.239 |               469.86 |              94.0478 |               93.972 |
|------------|----------------------|----------------------|----------------------|----------------------|


------------------------------ END VIC TIMING PROFILE ------------------------------
Contributor

dgergel commented Sep 5, 2017

An timing table with this branch from a 5-day RI run:

------------------------------ VIC TIMING PROFILE ------------------------------

  Date                      : Fri Sep  1 20:44:48 2017
  Compiler                  : icc (Intel(R) C++ gcc 4.3 mode)
  Machine                   : r8i4n0
  VIC User                  : gergel
  VIC Version               : unset
  VIC GIT Version           : 5.0.1 February 1, 2017
  VIC_DRIVER                : CESM

  Global Param File         : vic.globalconfig.txt
  Domain File               : /p/work2/projects/rasm/inputdata/share/domains/domain.lnd.wr50a_ar9v4.100920.nc
  Start Date                : 1948-09-01-00000
  Stop Date                 : 1948-09-06
  Nrecs                     : 120
  Model Timestep (seconds)  : 3600
  Snow Timestep (seconds)   : 3600
  Runoff Timestep (seconds) : 3600
  Atmos Timestep (seconds)  : 3600

  MPI Processes             : 64
  OPENMP Threads            : 1
  Total pes active          : 64
  pes per node              : 72

  Overall Metrics
  ---------------
    Model Cost       : 2401.31 pe-hrs/simulated_year
    Model Throughput : 0.639651 simulated_years/day

  Timing Table:
|------------|----------------------|----------------------|----------------------|----------------------|
| Timer      | Wall Time (secs)     | CPU Time (secs)      | Wall Time (secs/day) | CPU Time (secs/day)  |
|------------|----------------------|----------------------|----------------------|----------------------|
| Init Time  |              1.12486 |                 0.52 |             0.224971 |                0.104 |
| Run Time   |              1849.18 |              1846.94 |              369.835 |              369.388 |
| Final Time |            0.0232549 |                 0.01 |           0.00465097 |                0.002 |
| Total Time |              1850.32 |              1847.47 |              370.065 |              369.494 |
|------------|----------------------|----------------------|----------------------|----------------------|
| Force Time |             0.151743 |                 0.22 |            0.0303486 |                0.044 |
| Write Time |              470.239 |               469.86 |              94.0478 |               93.972 |
|------------|----------------------|----------------------|----------------------|----------------------|


------------------------------ END VIC TIMING PROFILE ------------------------------
@bartnijssen

This comment has been minimized.

Show comment
Hide comment
@bartnijssen

bartnijssen Sep 5, 2017

Member

Thanks for the timing table. @dgergel : Once you resolve the merge conflict I'll go ahead and merge the PR (it's a simple conflict in the release notes

Member

bartnijssen commented Sep 5, 2017

Thanks for the timing table. @dgergel : Once you resolve the merge conflict I'll go ahead and merge the PR (it's a simple conflict in the release notes

@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Sep 5, 2017

Contributor

@bartnijssen already resolved it (see above commit)

Contributor

dgergel commented Sep 5, 2017

@bartnijssen already resolved it (see above commit)

@jhamman jhamman merged commit 5317327 into UW-Hydro:develop Sep 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment