New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/move max iter grnd canopy #771

Merged
merged 13 commits into from Jan 31, 2018

Conversation

Projects
None yet
2 participants
@dgergel
Contributor

dgergel commented Jan 16, 2018

  • closes #770
  • tests passed
  • new tests added
  • science test figures
  • ran uncrustify prior to final commit
  • ReleaseNotes entry

dgergel added some commits Jan 16, 2018

@jhamman

Thanks. This looks pretty good. One change should be made before we merge.

Show outdated Hide outdated vic/vic_run/src/surface_fluxes.c Outdated

dgergel added some commits Jan 18, 2018

move MAX_ITER_GRND_CANOPY parameter update to initialize_parameters.c…
… in shared_all from surface_fluxes.c in vic_run
Merge branch 'feature/move_max_iter_grnd_canopy' of github.com:dgerge…
…l/VIC into feature/move_max_iter_grnd_canopy
@dgergel

This comment has been minimized.

Show comment
Hide comment
@dgergel

dgergel Jan 19, 2018

Contributor

@jhamman this is ready for another review.

Contributor

dgergel commented Jan 19, 2018

@jhamman this is ready for another review.

@jhamman jhamman merged commit 7b8196a into UW-Hydro:develop Jan 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dgergel dgergel referenced this pull request Feb 16, 2018

Merged

Feature/fix close energy bug #780

3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment