Skip to content

Conversation

@acherkashin
Copy link
Contributor

@acherkashin acherkashin commented May 29, 2022

Reason

I see the following reasons to introduce images support in this addon:

  1. In some cases, we need to use *.gif, *.jpeg, *.png instead of *.svg files
  2. In some projects contain legacy with many *.gif, *.jpeg, *.png files

Changes

Image loader was implemented in the same way as svg loader.

How it looks

image

image

Screenshot 2022-05-29 at 13 49 45

Screenshot 2022-05-29 at 14 02 41

@acherkashin acherkashin changed the title WIP: Features/add images support Add images support May 29, 2022
@Sqrrl Sqrrl merged commit 23cc16c into UX-and-I:master Jun 15, 2022
@Sqrrl
Copy link
Collaborator

Sqrrl commented Jun 15, 2022

Thanks. I've merged it "as is" for now (v2.4.0). I'm not sure, if it would be better to make it opt-in, though. The new tab could be undesired by some users.

@acherkashin
Copy link
Contributor Author

@Sqrrl thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants